Refactoring of forum application

[lemon-head]

I want to do some improvements on the forum application

Code gardening.

• replace tabs by spaces, and fix indentation
• comments using /**..*/

Structural Refactoring

• use the #458 RoxAppView? output buffering scheme.
• use the #459 RoxGenericPage? local $page object.

This can be a first step towards the more complex #436 RoxPageView scheme, but it doesn't have to be.

The advantages:

• Cleaner code (hopefully)
• Fewer lines wasted for redundant ob_start(), ob_end(), ob_get_contents(). However, this is not as important in the forums application as it is in other apps.
• The application gets independent from the global PVars::getObj('page') object.
• Easier transition to #436 RoxPageView scheme.

[lemon-head]

[4339] - does it.

[jeanyves]

please, I am really on forum, this make the merging a bit more difficult, can you wait a bit ?

except this : space instead of tabs, I am ok /* */ to replace // ? If it is the rule I don't like it they are cases where /* */ are very usefeull to make a block inactive for example

and other case where a // is very good to make a "title comment" before block or an additional comment in the end of a line, if you only use /* */, when you want to make inactive a big bloc you have to deal with all internal /* */, with // you dont have this problem.

May be I misunderstood your intention ?

[public]

There is a error message in the footer of the forum in alpha: Notice: Undefined variable: versionInfo in /home/bwrox/alpha.bewelcome.org/templates/apps/rox/footer.php on line 82

not sure if this is related to this ticket. crumbking